CRM-19273 Fix in the usage of insertedLines and added test #9998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19273 Fix in the usage of insertedLines and added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of code in #9621 after my review. All my changes have been to the unit tests, I kept the original change.
I have verified the bug is replicable through the UI & fixed by this. It is also replicable in the test & fixed by this.
The code being changed is not nice code, however, the change is constrained to a very specific function which is demonstrably broken.
I spent quite a bit of time on the test. I did some stylistic fixes to make it match other tests more and tried to remove the test's reliance on deleting the default price sets. However, I would up in a can of worms as we are pretty immature on our testing of event forms. So, settling for how it is.
Adding merge on pass