CRM-20282 Added credit card type field to bookkeeping report #9995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just picking off this one as it is the most straight forward. It tests fine & I can't see any gotchas. Can I just get you rebase & squash the 2 commits into one & then we can merge. Also, if you wanted to add pan_truncation, this would be the report to do it on |
---------------------------------------- * CRM-19997: Add Credit card type fields in contribution related reports https://issues.civicrm.org/jira/browse/CRM-19997 ---------------------------------------- * CRM-20282: https://issues.civicrm.org/jira/browse/CRM-20282 CRM-20282 Fixed report to read from card type rather than credit card type ---------------------------------------- * CRM-20282: Add credit card type field for Bookkeeping report https://issues.civicrm.org/jira/browse/CRM-20282
|
@eileenmcnaughton Done! |
|
Hmm - I'm not sure I would want to see it on all the reports, tbh I'm not even sure card type should be on all of them |
|
test this please |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20282 Added credit card type field to bookkeeping report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19997