Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20247 Add test & ensure $is_recur is assigned to the message_template. #9966

Merged
merged 3 commits into from
Mar 14, 2017
Merged

CRM-20247 Add test & ensure $is_recur is assigned to the message_template. #9966

merged 3 commits into from
Mar 14, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 12, 2017 •
edited by civicrm-builder
Loading

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this might affect you? I'm pretty confident in the fix

@eileenmcnaughton eileenmcnaughton force-pushed the is_recur_template branch 2 times, most recently from 47fd197 to d6693b3 Compare March 12, 2017 22:54
seamuslee001
seamuslee001 reviewed Mar 13, 2017
View reviewed changes
tests/phpunit/api/v3/ContributionTest.php Outdated
*
* @return array|int
*/
protected function createReceiptableContributionPage($params) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should set $params = array() here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@eileenmcnaughton
CRM-20247 Add test & ensure $is_recur is assigned to the message_temp…
d891a27 
…late.
@eileenmcnaughton
CRM-20247 further removal of ignored is_recur parameter.
6626a69 
This variable was part of a legacy flow via the BaseIPN. Removing the variable is a good tidy up step
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I updated in response to your review

@seamuslee001
Copy link
Contributor

Looks ok to me, Tests pass and i assume that there are enough tests to prove that its all fine for various receipt types

@eileenmcnaughton
Copy link
Contributor Author

Thanks @seamuslee001

@eileenmcnaughton eileenmcnaughton merged commit b4465ed into civicrm:master Mar 14, 2017
@eileenmcnaughton eileenmcnaughton deleted the is_recur_template branch March 14, 2017 00:30
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
@eileenmcnaughton
Merge pull request civicrm#9966 from eileenmcnaughton/is_recur_template
a19cdc8 
CRM-20247 Add test & ensure $is_recur is assigned to the message_template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @civicrm-builder