Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20232 Fix Relationship (Type) filter on Relationship report template. Any r… #9947

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

davidjosephhayes
Copy link
Contributor

…elationship types that were the same bidirectional (eg Sibling of) were completely fitlered out of the list of possibilities on the select box on the filter.

…elationship types that were the same bidirectional (eg Sibling of) were completely fitlered out of the list of possibilities on the select box on the filter.
@davidjosephhayes
Copy link
Contributor Author

I feel like there was a hack-ish reason null was a string. Maybe someone can enlighten me?

@yashodha yashodha added the master label Mar 8, 2017
@eileenmcnaughton
Copy link
Contributor

I can't imagine one! Can you log a JIRA for us to close this against so people understand the symptoms that were fixed?

@davidjosephhayes
Copy link
Contributor Author

@eileenmcnaughton eileenmcnaughton changed the title Fix Relationship (Type) filter on Relationship report template. Any r… CRM-20232 Fix Relationship (Type) filter on Relationship report template. Any r… Mar 8, 2017
@eileenmcnaughton eileenmcnaughton merged commit 43ab26f into civicrm:master Mar 8, 2017
@eileenmcnaughton
Copy link
Contributor

Thanks!

@agh1
Copy link
Contributor

agh1 commented Apr 4, 2017

@davidjosephhayes there are some quirky things regarding "null" because DB_DataObject treats it as NULL, but the only hacky thing I'm aware of is in https://issues.civicrm.org/jira/browse/CRM-15522 to take care of poor Mr. Null.

monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-20232 Fix Relationship (Type) filter on Relationship report template. Any r…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants