CRM-20224 - Cleanup internal event names #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`civi.dao.fooBar`) If you look at the list of events emitted through the EventDispatcher, you'll find several different formats for the names: ``` actionSchedule.getMappings actionSchedule.prepareMailingQuery api.authorize api.exception api.prepare api.resolve api.respond civi.core.install civi.token.eval civi.token.list civi.token.render DAO::post-delete DAO::post-insert DAO::post-update hook_civicrm_caseChange hook_civicrm_post::Activity hook_civicrm_post::Case hook_civicrm_unhandled_exception ``` This patch renames events using the `DAO::foo-bar` convention. Based on grepping universe, I don't believe any extensions rely on the `DAO::*` events.
…ivi.api.foo`) If you look at the list of events emitted through the EventDispatcher, you'll find several different formats for the names: ``` actionSchedule.getMappings actionSchedule.prepareMailingQuery api.authorize api.exception api.prepare api.resolve api.respond civi.core.install civi.token.eval civi.token.list civi.token.render DAO::post-delete DAO::post-insert DAO::post-update hook_civicrm_caseChange hook_civicrm_post::Activity hook_civicrm_post::Case hook_civicrm_unhandled_exception ``` This patch renames events using the `api.foo` convention. Based on grepping universe, I don't believe any extensions rely on the `DAO::*` events.
…ionSchedule.fooBar` vs `civi.actionSchedule.fooBar`) If you look at the list of events emitted through the EventDispatcher, you'll find several different formats for the names: ``` actionSchedule.getMappings actionSchedule.prepareMailingQuery api.authorize api.exception api.prepare api.resolve api.respond civi.core.install civi.token.eval civi.token.list civi.token.render DAO::post-delete DAO::post-insert DAO::post-update hook_civicrm_caseChange hook_civicrm_post::Activity hook_civicrm_post::Case hook_civicrm_unhandled_exception ``` This patch renames events using the `actionSchedule.fooBar` convention. Based on grepping universe, I don't believe any extensions rely on the `DAO::*` events.
|
This seems OK to me. They seem like recent additions so the checks seem good enough, and the changes are just hook names so I don't expect fall out |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20224 - Cleanup internal event names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the list of events emitted through the EventDispatcher,
you'll find several different formats for the names:
These patches rename some of the events to follow the conventions described
in CRM-20224. For each one that's renamed, I've grepped
universeto seeif any published extensions referenced these events using their internal
name. None did.