CRM-19453 #9890
Merged
CRM-19453 #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success at last? |
seamuslee001
approved these changes
Feb 23, 2017
There was a problem hiding this comment.
As per previous PR tested the changes on Linux and i think its fine @spalmstr I assume you have tested this on a windows install and works?
|
Wonderful! My Windows environment won't work without it as cms.root doesn't get resolved. |
|
Yes, success at last! |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at a PR of the same code. It was easier to recreate the branch than attempt to do another push to it as that push failed. I hope at last the PR will succeed.