(WIP) CRM-20160 - Remove restriction on which entities the Attachment api supports

[colemanw]

• CRM-20160: Attachment api does not work with all entities

[tunbola]

Tried this Fix on my local and was able to create an Attachment for the LeaveRequest Entity in CiviHR.

[colemanw]

@totten can you please review this?

[totten]

I think it's fine to continue putting discussion here, but I'm flagging this WIP because the discussion in #10010 indicates that we need major changes. If you'd rather close/reopen, that's also valid/appreciated.

[totten]

The discussion in the other PR is a bit long, but just to capture the gist of it -- DynamicFKAuthorize::authorizeDelegate() relies on a simulated/subordinate API call. DynamicFKAuthorization uses whitelist of entities because the API call is based on soft/informal expectations. I'd expect them to hold true as a matter of best-practice, but there's no historical or design reason to think that they actually do hold across the board.

[eileenmcnaughton]

@colemanw I'm going to close this because it appears to be long-term WIP & it seems it needs major changes. There was a suggestion half a year ago to close/re-open when ready - I think that makes sense