Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] towards CRM-19490 - code cleanup only. #9843

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 16, 2017

Removing unused variables & a bit of cruft in the test
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane assuming tests pass

@eileenmcnaughton
Copy link
Contributor Author

Applied merge on pass per Seamus review & per the fact this is very NFC

@eileenmcnaughton eileenmcnaughton merged commit 4b4cf11 into civicrm:master Feb 16, 2017
@eileenmcnaughton eileenmcnaughton deleted the test_clean branch February 16, 2017 03:26
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
[NFC] towards CRM-19490 - code cleanup only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants