CRM-20013 Localization for participant status on Event Income Report … #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeMurray
reviewed
Feb 14, 2017
| @@ -262,8 +262,8 @@ public function buildColumnHeaders() { | |||
| } | |||
| } | |||
|
|
|||
| $statusType1 = CRM_Event_PseudoConstant::participantStatus(NULL, 'is_counted = 1'); | |||
| $statusType2 = CRM_Event_PseudoConstant::participantStatus(NULL, 'is_counted = 0'); | |||
| $statusType1 = CRM_Event_PseudoConstant::participantStatus(NULL, 'is_counted = 1', 'label'); | |||
There was a problem hiding this comment.
This looks like a correct invocation of https://github.com/civicrm/civicrm-core/blob/master/CRM/Event/PseudoConstant.php#L137
|
Agree with Joe's comments, I assume you have tested his @francescbassas and it works for you? @mlutfy does this make sense to you? |
|
Yes @seamuslee001, tested and working. |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20013 Localization for participant status on Event Income Report …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(Summary)