CRM-20007 Add test to prove that repeatTransaction does not use the P… #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayment Procesors Payment Instrument when creating contributions
|
ping @eileenmcnaughton I think this is what you were looking for right? |
seamuslee001
commented
Feb 12, 2017
| 'trxn_id' => uniqid(), | ||
| 'original_contribution_id' => $contribution1, | ||
| )); | ||
| $this->assertEquals(array_search('Debit Card', $paymentInstruments), $contribution2['values'][$contribution2['id']]['payment_instrument_id']); |
There was a problem hiding this comment.
That is what is used in the PaymentProcessor create in the test suite
…hat its using default payment instrument
|
pinging @andrew-cormick-dockery @ineffyble @MrLavaLava You folks may be interested in this. |
|
I've taken a look at this & agree that the test replicates a real issue & the fix is appropriate |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20007 Add test to prove that repeatTransaction does not use the P…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ayment Procesors Payment Instrument when creating contributions