CRM-19979 Fix issue where contacts cannot be removed from group or deleted if in status of pending

[seamuslee001]

• CRM-19979: GroupContact.delete does not work for contacts with status of Pending

[seamuslee001]

@BorislavZlatanov I have opened this PR to fix your issue, Have been able to reproduce issue in a unit test which is always a good sign

[seamuslee001]

@BorislavZlatanov I believe i now have a fix for this in the commit #518dd0e

[eileenmcnaughton]

Does the status field support IN rather than doing 2 calls?

ie. status_id => array('IN' => array('Pending', 'Removed'))

• alternatively could we only check for pending if removed is empty

[seamuslee001]

Possibly i'm not sure, I'll give it try @eileenmcnaughton

[seamuslee001]

@eileenmcnaughton tested it and does support IN and i also added Pending onto the check for if we have been supplied a status of Added

[BorislavZlatanov]

@seamuslee001 I applied your latest patch to 4.7.14 and tried it.

When trying to delete from group a contact that has Pending status, I got the "Cannot Delete GroupContact" error.

When removing from group a contact that has Pending status, it removed it successfully with no errors. When deleting from group this contact that now has Removed status, it deleted it with no errors.

[seamuslee001]

@BorislavZlatanov I believe with the latest commit I have solved the issue where pending cannot be "Deleted"

[BorislavZlatanov]

@seamuslee001 Yes, I tested and both Removing and Deleting worked now. Thanks!

[eileenmcnaughton]

Thanks @seamuslee001 & @BorislavZlatanov - looks good to me & has unit testing! and with your testing @BorislavZlatanov I'm happy to approve