-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM:4287 - add searchPrimaryDetailsOnly setting #9772
Conversation
…atches as results
…PrimaryDetailsOnly". Location types are not primaries, contact could have several emails of any location type but only one email (not location type) should be their "primary".
@@ -514,7 +514,7 @@ public function initialize($apiEntity = NULL) { | |||
CRM_Financial_BAO_FinancialType::buildPermissionedClause($this->_whereClause, $component); | |||
} | |||
|
|||
$this->_fromClause = self::fromClause($this->_tables, NULL, NULL, $this->_primaryLocation, $this->_mode); | |||
$this->_fromClause = self::fromClause($this->_tables, NULL, NULL, $this->_primaryLocation, $this->_mode, $apiEntity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I last looked at this apiEntity seemed to duplicate $this->_mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually $this->_mode contain the constant values specified in https://github.com/jitendrapurohit/civicrm-core/blob/master/CRM/Contact/BAO/Query.php#L47 and apiEntity
is assigned with string entity values e.g. Contact, Participant etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the record, I still don't understand how that isn't just duplicating mode in a different format (you don't need to respond to this - it has been merged & it is not a 'live' concern)
Also works for phone, im and openid |
CRM:4287 - add searchPrimaryDetailsOnly setting
Does this work for QuickSearch - or will that require additional work? @jitendrapurohit an estimate if that is the case pls |
https://issues.civicrm.org/jira/browse/CRM-4287