Minor comment fixes & function extraction. #9751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeMurray
reviewed
Feb 23, 2017
| * Get all the phone numbers for a specified location_block id, with the primary phone being first | ||
| * Get all the phone numbers for a specified location_block id, with the primary phone being first. | ||
| * | ||
| * This is called from CRM_Core_BAO_Block as a calculated function. |
There was a problem hiding this comment.
I don't think it is good form to say in comments where something is called from, as that can get dated.
|
The code changes look fine, but I haven't tested to see if the refactoring of some code into two functions is working, nor checked to see if $tree was being accessed from outside the class inappropriately and thus making it protected causing a error to be raised. |
|
tested this and looks file to me |
|
@eileenmcnaughton have rebased it for you |
acf3e51 to
074dd76
Compare
|
added merge on based based on @seamuslee001 testing |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
Minor comment fixes & function extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.