Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19937 - ensure amount preceded by $ is still treated as a number #9745

Merged
merged 2 commits into from
Feb 28, 2017
Merged

CRM-19937 - ensure amount preceded by $ is still treated as a number #9745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
210072f
CRM-19937 - ensure amount preceded by $ is still treated as a number
jmcclelland Jan 27, 2017
f250964
CRM-19937: use localized symbol instead of dollar sign
jmcclelland Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/CRM/Price/Form/Calculate.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ function calculateSelectLineItemValue(priceElement) {
*/
function calculateText(priceElement) {
//CRM-16034 - comma acts as decimal in price set text pricing
var textval = parseFloat(cj(priceElement).val().replace(thousandMarker, ''));
//CRM-19937 - dollar sign easy mistake to make by users.
var textval = parseFloat(cj(priceElement).val().replace(thousandMarker, '').replace(symbol, ''));

if (isNaN(textval)) {
textval = parseFloat(0);
Expand Down