Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRM-15984: "Add campaign field on Email activity form" #9737

Closed
wants to merge 1 commit into from
Closed

Fix CRM-15984: "Add campaign field on Email activity form" #9737

wants to merge 1 commit into from

Conversation

twomice
Copy link
Contributor

@twomice twomice commented Jan 25, 2017 •
edited by civicrm-builder
Loading

@twomice twomice changed the title Fix CRM-15984: "Add campaign field on Email activity form" (WIP) Fix CRM-15984: "Add campaign field on Email activity form" Jan 25, 2017
@twomice
Copy link
Contributor Author

twomice commented Jan 25, 2017

Jenkins test this please.

1 similar comment
@twomice
Copy link
Contributor Author

twomice commented Jan 26, 2017

Jenkins test this please.

@twomice twomice changed the title (WIP) Fix CRM-15984: "Add campaign field on Email activity form" Fix CRM-15984: "Add campaign field on Email activity form" Jan 26, 2017
@twomice twomice changed the title Fix CRM-15984: "Add campaign field on Email activity form" (WIP) Fix CRM-15984: "Add campaign field on Email activity form" Jan 27, 2017
@twomice twomice force-pushed the CRM-15984-b_email_activity_campaign branch from 78d0e52 to 8229046 Compare January 29, 2017 21:48
@twomice twomice changed the title (WIP) Fix CRM-15984: "Add campaign field on Email activity form" Fix CRM-15984: "Add campaign field on Email activity form" Jan 29, 2017
@twomice
Copy link
Contributor Author

twomice commented Jan 29, 2017

Yay, finally passing tests!

jitendrapurohit
jitendrapurohit approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'd the changes and confirmed that the campaign field is correctly added to Email Activity task.

@jitendrapurohit
Copy link
Contributor

@twomice PR has gone stale, would require a rebase + push in order to let someone merge it.

@jitendrapurohit jitendrapurohit mentioned this pull request May 8, 2017
Merged
@jitendrapurohit
Copy link
Contributor

cherry-picked the changes and created an updated PR at #10317.

@eileenmcnaughton
Copy link
Contributor

Closing as replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendrapurohit jitendrapurohit jitendrapurohit approved these changes

Assignees
No one assigned
Labels
important master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twomice @jitendrapurohit @eileenmcnaughton @civicrm-builder