Comments #9658
Comments #9658
Conversation
| @@ -134,7 +134,7 @@ public function postProcess() { | |||
| // Get the permissions into a format that matches what we get from WP | |||
| $allWarningPermissions = CRM_Core_Permission::getAnonymousPermissionsWarnings(); | |||
| foreach ($allWarningPermissions as $key => $permission) { | |||
| $allWarningPermissions[$key] = CRM_utils_String::munge(strtolower($permission)); | |||
| $allWarningPermissions[$key] = CRM_Utils_String::munge(strtolower($permission)); | |||
There was a problem hiding this comment.
fix casing to be correct
| @@ -341,7 +341,7 @@ public static function formRule($fields, $files, $self) { | |||
| return TRUE; | |||
| } | |||
|
|
|||
| return parent::formrule($fields, $files, $self); | |||
| return parent::formRule($fields, $files, $self); | |||
There was a problem hiding this comment.
fix casing to be correct
| @@ -41,7 +41,7 @@ class CRM_Case_Form_Task_Print extends CRM_Case_Form_Task { | |||
| * Build all the data structures needed to build the form. | |||
| */ | |||
| public function preProcess() { | |||
| parent::preprocess(); | |||
| parent::preProcess(); | |||
There was a problem hiding this comment.
fix casing to be correct
| @@ -206,11 +235,12 @@ public static function getExports($dao, $labelName, $prefix, $foreignDAOs) { | |||
| $exports = array(); | |||
| $fields = $dao::fields(); | |||
|
|
|||
| foreach($fields as $name => $field) { | |||
| foreach ($fields as $name => $field) { | |||
There was a problem hiding this comment.
whitespace - this file is probably ignored as it used to be autogenerated
| @@ -816,7 +816,7 @@ public function changeSubscriptionAmount(&$message = '', $params = array()) { | |||
|
|
|||
| curl_close($submit); | |||
|
|
|||
| $responseFields = $this->_ParseArbReturn($response); | |||
| $responseFields = $this->_parseArbReturn($response); | |||
There was a problem hiding this comment.
fix casing to be correct
| @@ -1,10 +1,12 @@ | |||
| <?php | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
template for civicrm.version.php
| @@ -36,7 +36,14 @@ | |||
| */ | |||
| class CRM_Core_I18n_SchemaStructure | |||
| {ldelim} | |||
| static function &columns() | |||
There was a problem hiding this comment.
template for SchemaStructure
| * @return array | ||
| * A table-indexed array of translatable columns. | ||
| */ | ||
| public static function &columns() |
There was a problem hiding this comment.
I desperately want to remove the & too but not mixing it in
| * @return array | ||
| */ | ||
| public static function mailingGroupEntityTables($context = NULL) { |
There was a problem hiding this comment.
I would check with @totten on this one
There was a problem hiding this comment.
Actually it looks like it was @colemanw who edited that fn so the var is not removed without removing it - any reason C?
There was a problem hiding this comment.
Ah, I see. The function works kind of like a hook, in that the caller will pass in that variable whenever calling a *EntityTables function whether it's needed or not. In this case it's not needed. Fine to remove it or document it.
| public function setDefaultValues() { | ||
| $dafaults = array(); |
There was a problem hiding this comment.
Funny thing is that php won't care. Unless of course the two conditionals below are false. I guess one or the other is always true or else people would have noticed an undefined var notice.
No description provided.