Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ready-for-core-team-review]CRM-19585, fixed tax issues #9590

Merged
merged 4 commits into from
Dec 29, 2016

Conversation

pradpnayak
Copy link
Contributor

@pradpnayak pradpnayak commented Dec 28, 2016

…rectly

----------------------------------------
* CRM-19585: Sales tax issue
  https://issues.civicrm.org/jira/browse/CRM-19585
----------------------------------------
* CRM-19585: Sales tax issue
  https://issues.civicrm.org/jira/browse/CRM-19585
----------------------------------------
* CRM-19585: Sales tax issue
  https://issues.civicrm.org/jira/browse/CRM-19585
@pradpnayak pradpnayak changed the title CRM-19585, fixed tax issues [ready-for-core-team-review]CRM-19585, fixed tax issues Dec 28, 2016
@pradpnayak
Copy link
Contributor Author

To replicate
Add Sales tax Relationship For Donation Financial type with 10% tax

  1. Create contribution from New contribution form for FT = Donation and Amount = 100
    expected result:
    total amount = 110
    contrbution.tax_amount = 10

actual result:
total amount = 110
contrbution.tax_amount = 10.10

And

  1. Create Contribution from New contribution form for FT = Campaign Contribution and Amount = 100
    expected result:
    total amount = 100

actual result:
total amount = 100.10

Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both above mentioned issues are fixed.

@monishdeb monishdeb merged commit 02862ee into civicrm:master Dec 29, 2016
@pradpnayak pradpnayak deleted the CRM-19585-6 branch February 22, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants