Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19802 - Fix more translated strings in tpls #9587

Merged
merged 1 commit into from
Jan 30, 2017
Merged

CRM-19802 - Fix more translated strings in tpls #9587

merged 1 commit into from
Jan 30, 2017

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Dec 28, 2016 •
edited by civicrm-builder
Loading

@colemanw
Copy link
Member Author

@mlutfy feel like reviewing this one?

@mlutfy mlutfy self-requested a review January 30, 2017 19:50
mlutfy
mlutfy approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@mlutfy mlutfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems OK

indeed using the javascript ts() in smarty is a common error, but then strings don't get loaded correctly because it doesn't go through the CRM_Core_Resources loader.

@colemanw
Copy link
Member Author

Yea. Maybe we could fix that... but how much more energy do we really want to put into this old version of smarty?

@colemanw colemanw merged commit d0fcf9d into civicrm:master Jan 30, 2017
@colemanw colemanw deleted the CRM-19802 branch January 30, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlutfy mlutfy mlutfy approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @mlutfy @civicrm-builder