Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ready-for-core-team-review]CRM-19585, created function to calculate financial item amount when co… #9574

Merged
merged 1 commit into from
Dec 28, 2016
Merged

[ready-for-core-team-review]CRM-19585, created function to calculate financial item amount when co… #9574

merged 1 commit into from
Dec 28, 2016

Conversation

pradpnayak
Copy link
Contributor

…ntribution is updated

Added test

@pradpnayak
CRM-19585, created unction to calculate financial item amount when co…
d9553c2 
…ntribution is updated

Added test

----------------------------------------
* CRM-19585: Sales tax issue
  https://issues.civicrm.org/jira/browse/CRM-19585
@pradpnayak pradpnayak changed the title CRM-19585, created unction to calculate financial item amount when co… CRM-19585, created function to calculate financial item amount when co… Dec 23, 2016
@pradpnayak pradpnayak changed the title CRM-19585, created function to calculate financial item amount when co… [ready-for-core-team-review]CRM-19585, created function to calculate financial item amount when co… Dec 23, 2016
@jitendrapurohit
Copy link
Contributor

@pradpnayak Is this replacement/dependent on any other PR?

@pradpnayak
Copy link
Contributor Author

This is part of #9340
We are submitting PR in chunks for the changes.

jitendrapurohit
jitendrapurohit approved these changes Dec 26, 2016
View reviewed changes
Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so this changes would work fine provided all the keys exist in input params.

@monishdeb monishdeb merged commit ae78ec3 into civicrm:master Dec 28, 2016
@pradpnayak pradpnayak mentioned this pull request Dec 28, 2016
Closed
@pradpnayak pradpnayak deleted the CRM-19585-1 branch February 22, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendrapurohit jitendrapurohit jitendrapurohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradpnayak @jitendrapurohit @monishdeb