tools/scripts/phpunit-ls - Fix PhpStorm lookup of PHPUnit_Framework_TestCase #9535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estCase When using PhpStorm, code completion doesn't work smoothly on classes which extend `PHPUnit_Framework_TestCase` because there are two copies: the real copy and then a placeholder class used by `tools/scripts/phpunit-ls`. Wrapping the placeholder copy in `eval()` prevents PhpStorm from identifying.
|
@agh1 I just tried to push Coleman to log a JIRA for a trivial change since you are doing release notes now & I feel we need to be tighter on issues to respect that. Is there a bar below which we don't need to - this seems trivial & obscure but ... I dunno |
|
@eileenmcnaughton I think the threshold for issues can be "notability". If it's something I might ever mention to a coworker, it deserves an issue, i.e.
On the other hand, I'd never tell Tyrell, "Check out this exciting stuff @totten is wrapping with |
|
OK I'm merging this - the change only affects an obscure developer aspect and is very low risk so I feel Tim's testing / analysis is enough here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PhpStorm, code completion doesn't work smoothly on classes which
extend
PHPUnit_Framework_TestCasebecause there are two copies: the realcopy and then a placeholder class used by
tools/scripts/phpunit-ls.Wrapping the placeholder copy in
eval()prevents PhpStorm fromidentifying.