CRM-19621 Fix fatal error caused by previous version of fix #9461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seamuslee001
commented
Nov 29, 2016
•
- CRM-19621: Contribution "confirm" page does not display state/country
|
@eileenmcnaughton @monishdeb @jitendrapurohit this fixes the fatal error i found whilst keeping most of Jitendra's fix in tact. Can you please verify that it still fixes the original problem? |
|
@seamuslee001 OK - the reservation I had about the original fix was that it altered CRM_Payment_Form which is used multiple code paths, and I wasn't sure what the impact was across them all. This has a test fail :-( |
|
& to put that in perspective - I realise it was fixing something introduced by a patch affecting multiple code paths - but this is a change to the rc - so going backwards feels safer than ploughing on in the context of the rc |
|
@seamuslee001 @eileenmcnaughton can it be closed in favor of #9466 ? |
|
replaced by #9466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.