Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19303 #9409

Merged
merged 5 commits into from
Nov 21, 2016
Merged

CRM-19303 #9409

merged 5 commits into from
Nov 21, 2016

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Nov 17, 2016

Milton Zurita and others added 5 commits November 18, 2016 07:37
Instead of assuming the default folder exists, it checks, if not it will search nearby directories for the files.
Final Style Changes.  Other warnings not in my modifications. Line# 40-51
@seamuslee001
Copy link
Contributor Author

Replacement PR for #9088 ping @colemanw

Copy link
Member

@colemanw colemanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@colemanw colemanw merged commit 7f57eaf into civicrm:master Nov 21, 2016
@colemanw
Copy link
Member

colemanw commented Nov 21, 2016

@MiltoxBeyond looks like there's still a problem with this PR not finding the correct directory. See comments in https://issues.civicrm.org/jira/browse/CRM-19303

@samuelsov
Copy link
Contributor

The patch doesn't seems to be in master.
Was it reverted ?

@seamuslee001
Copy link
Contributor Author

yeh it got reverted as per comments on ticket. Coleman then came up with this as an alternate #9458

@samuelsov
Copy link
Contributor

Ok, thanks for the information. I will look at the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants