-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-19658 test for is_email_receipt override #9403
Conversation
Orginal JIRA ticket: https://issues.civicrm.org/jira/browse/CRM-19601 |
Jenkins test please |
Jenkins test this please! |
Ok - so the test is 'correctly' failing -> as that's why we need #9353 |
test this please |
I've just copied the above test to demonstrate how to test no email actually goes out - that would be a valuable addition here
|
@eileenmcnaughton - What if that message/text ' Please print this receipt for your records. ' changes? It would make this test fail. I decided to go with a test to check if a receipt_date is recorded. But of course that also contains assumptions. |
@KarinG yep - it does cause the test to fail & people have to fix it - but I think that level of brittleness is ok because if it is a real result of a change the person will be able to identify easily. NB you don't have to take this further - I did merge it - but maybe someone preparing for gsoc will |
Added a test for #9353