CRM-19380 allow for multiple from email addresses but only one per do… #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91b07c9 to
17a52c1
Compare
|
@eileenmcnaughton thoughts Eileen? |
| @@ -258,15 +258,22 @@ public static function addOptionValue(&$params, &$groupParams, &$action, &$optio | |||
| * @param int $optionGroupID | |||
| * @param string $fieldName | |||
| * The name of the field in the DAO. | |||
| * @param bool $domainSpecific | |||
| * Dos this option groujp allow for duplicate options that are | |||
There was a problem hiding this comment.
!! Dos this read right to you?:-)
|
test this please |
|
@eileenmcnaughton should this get merged? |
| @@ -177,10 +177,12 @@ public function buildQuickForm() { | |||
| 'addressee', | |||
| )) && !$isReserved | |||
| ) { | |||
| $domainSepcificOptionGroups = array('from_email_address'); | |||
There was a problem hiding this comment.
Sepcificallly.... this is a typo
|
This seems to make sense - just adding the admin side of storing domain specific settings. Needs someone to give it a quick test though |
ba10cd4 to
0c1e132
Compare
|
Tested. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…main