CRM-19325 - enable search for contributions that are not in any batch. #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -568,6 +568,9 @@ public static function whereClauseSingle(&$values, &$query) { | |||
|
|
|||
| case 'contribution_batch_id': | |||
| $batches = CRM_Contribute_PseudoConstant::batch(); | |||
| // The key 'NULL' indicates that the user is looking for contributions | |||
| // that are not contained in a batch, see CRM-19325. | |||
| $batches['NULL'] = ts('(none)'); | |||
There was a problem hiding this comment.
@johanv Johan why not set here $op = 'IS NULL' and $value = '' if $batches = 'NULL' ? It would be similar to L345 of this file and then i think you wouldn't need the changes in the CRM_Contact_BAO_Query i don't think
There was a problem hiding this comment.
Thank you for pointing this out. I will look at this, but probably not this week.
|
@johanv are you working on the changes mentioned above ? |
|
No I am not, sorry. I have little time to work on core CiviCRM for the moment. |
|
No problem, am marking it with [WIP] so you can continue later. |
|
Closing in favor of #9492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 'none' to the 'contribution name' drop down on the contribution search form. This allows searching for contributions not in any batch.