Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CRM-19306: Fix documentation for upload directories in civicrm.… #8979

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

ergonlogic
Copy link
Contributor

…settings.php template.

Fixes: https://issues.civicrm.org/jira/browse/CRM-19306.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@totten
Copy link
Member

totten commented Sep 5, 2016

jenkins, ok to test

@totten
Copy link
Member

totten commented Sep 5, 2016

Review notes:

  • The reported test failure (CivicrmUpgradeTest.4_2_9-multilingual_af_bg_en_mysql_bz2) is a pre-existing problem.
  • Verified that that there is a cleanup logic which deletes uploadDir and could not find similar logic for customFileUploadDir.
  • Grepping for >cleanup(, I could only find one use case (doSiteMove()) which would actually delete uploadDir, so it may be particularly temporary in practice.
  • Between the two, agree that uploadDir is more temporary, so this seems like an improvement. Merging.

Thanks, Chris!

@totten totten merged commit a40f03c into civicrm:master Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants