Reports: CRM-19175 fix add to group, CRM-19170 performance on group filters #8820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eileenmcnaughton
commented
Aug 4, 2016
•
- CRM-19175: Contribution Report set to "contribution only" returns error on Add to Group
- CRM-19170: Improve performance on group filter (Contribution reports)
b24faf5 to
8edad8a
Compare
8edad8a to
7dedcf5
Compare
|
will apply to ubox today will report back |
…oft credits. This also includes some tidy up of the code, getting rid of the overriding of the signature
Remove unused return variable, fix comments, remove duplicate key
This reduced the time in testing from 190+ seconds (killed at that point) to ~1 second for a report with a small result set on a large DB
…nt group queries. The process of switching them over is not hard but they need to be looked at one-be-one
7dedcf5 to
8775528
Compare
|
Tested this on AUG, seems fine to merge, Just noting a php warning displays if a campaign a contribution is associated with is disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.