CRM-19122 Group Organization & parent default code should be the same #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eileenmcnaughton
commented
Jul 25, 2016
•
- CRM-19122: Group Organization & parent default code should be the same
|
Jenkins re test this please |
| public function setDefaultValues() { | ||
| $defaults = array(); | ||
| if (empty($defaults['parents'])) { | ||
| $defaults['parents'] = CRM_Core_BAO_Domain::getGroupId(); |
There was a problem hiding this comment.
@eileenmcnaughton I notice here that you are setting the default as having a parent group here, I am just wondering how that works with multisite given iirc in multisite extension we are looking at default being the domain org contact not the domain group
There was a problem hiding this comment.
hmm - have I changed the behaviour? Wouldn't that still be overridden?
There was a problem hiding this comment.
I think it might but it was just a thought,
There was a problem hiding this comment.
I just checked & this behaviour is also in CRM_Group_Form_Edit - the multisite extension overrides it.
- would be good to get this merged
eb2f8ee to
d44e3ae
Compare
|
@seamuslee001 thoughts? |
|
with your comment @eileenmcnaughton happy for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.