-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation UI: Aligns header block, matches h1 colour. #30845
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
Thanks @vingle . Looking forward to doing more installs from my mobile 😁 Just dropping a Standalone ticket which hopefully fixed by this change https://lab.civicrm.org/dev/core/-/issues/5074 |
It's so much fun. iOS is the perfect development OS.
Yes it should definitely fix that. Not that I have a > 2000px screen to check (as I'm doing all my css work on my phone obvs) |
Pre-install = all good Standalone Post install Standalone good WP seems to redirect straight to dashboard after install, so no confirmation page? So trivially good D7 is a bit unstyled - though as far as I can see that's the same/before after this PR D10 UI installer doesn't seem to use these screens. Didn't try Joomla (For the above I:
|
Looks good to merge to me, but will hold off a bit in case @JGaunt has any comments. |
@vingle needs rebase |
@mattwire done. |
Overview
The header on the installation screen used in Standalone, WordPress and others uses % positioning which creates variable alignment. This swaps to Flexbox to create consistent positioning, and a responsive fall back for small screens.
Before
Desktop:
Tablet:
Mobile:
After
Technical Details
The animation on the title text is adjusted to accommodate this (it's a smaller slide in from the other direction), with the h1 colour matching the rest of the text.
Comments
I did my best to avoid changing any other css / design, beyond removing the horizontal rule and changing 'font-family: Arial, sans-serif' to 'font-family: sans-serif' to give neater OS integration. @JGaunt – I really don't want to step on your work here, so please feel free to push back!