dev/core#5082 Ensure that urls are correctly formatted if mailing url… #29850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5082 |
… is not converted to trackable format and there are no static params only token ones
c914ad9 to
4a42461
Compare
|
Thanks @seamuslee001 Happy Easter 🐰🐣🐰 |
artfulrobot
reviewed
Apr 12, 2024
| @@ -141,7 +141,7 @@ private static function getTrackerURLForUrlWithTokens($url, $mailing_id, $queue_ | |||
| // Append the tokenised bits and the fragment. | |||
| if ($tokenised_params) { | |||
| // We know the URL will already have the '?' | |||
There was a problem hiding this comment.
This comment is apparently incorrect, given the need for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is not converted to trackable format and there are no static params only token ones
Overview
This fixes a bug where a url like http://civicrm.org/civicrm/mailing/view?id={mailing.key}&{contact.checksum}&cid={contact.contact_id} as being converted to http://civicrm.org/civicrm/mailing/view&id={mailing.key}&{contact.checksum}&cid={contact.contact_id}
Before
Url mangled
After
url not mangled
ping @totten @eileenmcnaughton @agileware-justin