dev/core#5079 Handle money localization before anything else in formRule

[eileenmcnaughton]

Overview

dev/core#5079 Handle money localization before anything else in formRule

Before

See https://lab.civicrm.org/dev/core/-/issues/5079

After

Localized & non-numeric values are handled in the Contribution Main formRule function

Technical Details

This ensures the values are passed through the de-localization functions before any more handling is done

Comments

@MegaphoneJon

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5079

[MegaphoneJon]

This works if someone's put in a localized value (e.g. 5.000$) but doesn't handle alpha characters ("5 dollars"). But it got me looking at the right part of the code. I'll put up an alternate and you can tell me what you think.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@MegaphoneJon I pushed it in - also with a small change for https://lab.civicrm.org/dev/core/-/issues/5100 as reported by @wmortada

[eileenmcnaughton]

@MegaphoneJon is this all good to merge? I see you closed the other

[wmortada]

I've tested this and can confirm that it fixes https://lab.civicrm.org/dev/core/-/issues/5100.

It also appears to fix https://lab.civicrm.org/dev/core/-/issues/5079 as far as I understand this issue. It couldn't reproduce the issue for '5 dollars' but I could reproduce the issue with '$5.00' and can confirm that this fixes the issue.

I've created two separate PRs to backport the fix for dev/core#5100:

• 5.71 dev/core#5100 Record other amount as unit price not quantity #29776
• 5.69 dev/core#5100 Record other amount as unit price not quantity #29777