Specify rounding mode when rendering Monetary entity tokens #29654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify rounding mode when rendering Monetary entity tokens, avoids RoundingModeException
Overview
Found when investigating why Schedule Reminders would not send.
Rendering Monetary tokens was failing due to no rounding mode being set.
Before
Formatting Money amounts is attempted in token rendering without rounding mode specified. If rounding is required, Brick will instead throw an exception, because it needs to be told how to round.
The conditions under which this is required are not especially clear, however it's probably a result of implementing Tax.
After
Specifies a rounding mode when rendering monetary amounts for tokens. Does not throw an exception when it needs to round.
Technical Details
One line change... I also reviewed other places where
Brick\Money\Money::of
is in use and found most other places are already specifying HALF_UP as the rounding mode, which makes sense.