Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify rounding mode when rendering Monetary entity tokens #29654

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

agileware-fj
Copy link
Contributor

Specify rounding mode when rendering Monetary entity tokens, avoids RoundingModeException

Overview

Found when investigating why Schedule Reminders would not send.
Rendering Monetary tokens was failing due to no rounding mode being set.

Before

Formatting Money amounts is attempted in token rendering without rounding mode specified. If rounding is required, Brick will instead throw an exception, because it needs to be told how to round.

The conditions under which this is required are not especially clear, however it's probably a result of implementing Tax.

After

Specifies a rounding mode when rendering monetary amounts for tokens. Does not throw an exception when it needs to round.

Technical Details

One line change... I also reviewed other places where Brick\Money\Money::of is in use and found most other places are already specifying HALF_UP as the rounding mode, which makes sense.

Copy link

civibot bot commented Mar 7, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 7, 2024
@agileware-fj
Copy link
Contributor Author

Agileware ref CIVICRM-2228

@eileenmcnaughton
Copy link
Contributor

@agileware-fj - check the style warning

@eileenmcnaughton
Copy link
Contributor

We do this in the Money::format() function so this makes sense

@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.72 March 7, 2024 05:49
@civibot civibot bot added 5.72 and removed master labels Mar 7, 2024
@eileenmcnaughton
Copy link
Contributor

We just forked 5.72 but I think it's reasonable to target this against 5.72 as it could be experienced as a regression so I changed the branch

@eileenmcnaughton eileenmcnaughton merged commit 9134c20 into civicrm:5.72 Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants