Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a few more assign_by_ref with assign (Smarty) #29603

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Replace a few more assign_by_ref with assign (Smarty) #29603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CRM/Report/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3366,7 +3366,7 @@ public function moveSummaryColumnsToTheRightHandSide() {
*/
public function doTemplateAssignment(&$rows) {
$this->assign('columnHeaders', $this->_columnHeaders);
$this->assign_by_ref('rows', $rows);
$this->assign('rows', $rows);
$this->assign('statistics', $this->statistics($rows));
}

Expand Down Expand Up @@ -3762,7 +3762,7 @@ public function setPager($rowCount = NULL) {
}

$pager = new CRM_Utils_Pager($params);
$this->assign_by_ref('pager', $pager);
$this->assign('pager', $pager);
$this->ajaxResponse['totalRows'] = $this->_rowsFound;
}
}
Expand Down
4 changes: 2 additions & 2 deletions CRM/Report/Form/Contact/Detail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,8 +843,8 @@ public function postProcess(): void {
unset($this->_columnHeadersComponent[$componentTitle][$id_header], $this->_columnHeadersComponent[$componentTitle][$contact_header]);
}

$this->assign_by_ref('columnHeadersComponent', $this->_columnHeadersComponent);
$this->assign_by_ref('componentRows', $componentRows);
$this->assign('columnHeadersComponent', $this->_columnHeadersComponent);
$this->assign('componentRows', $componentRows);
}

$this->doTemplateAssignment($rows);
Expand Down
6 changes: 3 additions & 3 deletions CRM/Report/Form/Event/Income.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function buildEventReport($eventIDs) {
$eventSummary[$eventDAO->event_id][ts('Registered Participant')] = "{$eventDAO->participant} (" . implode(', ', $this->getActiveParticipantStatuses()) . ")";
$currency[$eventDAO->event_id] = $eventDAO->currency;
}
$this->assign_by_ref('summary', $eventSummary);
$this->assign('summary', $eventSummary);

$activeParticipantClause = " AND civicrm_participant.status_id IN ( " . implode(',', array_keys($this->getActiveParticipantStatuses())) . " ) ";
//Total Participant Registerd for the Event
Expand Down Expand Up @@ -198,7 +198,7 @@ public function buildEventReport($eventIDs) {
}
$rows[ts('Payment Method')] = $instrumentRows;

$this->assign_by_ref('rows', $rows);
$this->assign('rows', $rows);
if (!$this->_setVariable) {
$this->_params['id_value'] = NULL;
}
Expand Down Expand Up @@ -254,7 +254,7 @@ public function setPager($rowCount = NULL) {
];

$pager = new CRM_Utils_Pager($params);
$this->assign_by_ref('pager', $pager);
$this->assign('pager', $pager);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions CRM/Report/Form/Membership/Summary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ public function postProcess() {
}
$this->formatDisplay($rows);

$this->assign_by_ref('columnHeaders', $this->_columnHeaders);
$this->assign_by_ref('rows', $rows);
$this->assign('columnHeaders', $this->_columnHeaders);
$this->assign('rows', $rows);
$this->assign('statistics', $this->statistics($rows));

if (!empty($this->_params['charts'])) {
Expand Down
2 changes: 1 addition & 1 deletion CRM/SMS/Form/Schedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function buildQuickform() {
$preview = [];
$preview['type'] = CRM_Core_DAO::getFieldValue('CRM_Mailing_DAO_Mailing', $this->_mailingID, 'body_html') ? 'html' : 'text';
$preview['viewURL'] = CRM_Utils_System::url('civicrm/mailing/view', "reset=1&id={$this->_mailingID}");
$this->assign_by_ref('preview', $preview);
$this->assign('preview', $preview);
}

/**
Expand Down