Cleans up some old accordion classnames still being used with details/summary #29600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first new
<details><summary>
accordions created during the December 2023 sprint kept the old classes.crm-accordion-wrapper
&.crm-accordion-header
names for design consistency.Once civicrm.css was updated to style details+summary directly, with utility classes
.crm-accordion-bold > summary
to replace.crm-accordion-header
&.crm-accordion-light > summary
to replace.crm-accordion-header.crm-master-accordion-header
, those old class names stopped being needed. The recent accordion PRs (#29448, #29533) have already swapped the old class names/patterns to the new ones across most Civi accordions.The JS file in particular needs updating as it generates accordions used in multiple parts of Civi.
Before
Old classnames.
After
New, fewer classnames.
Comments
Greenwich theme handles the new classnames. Other themes need to make sure they support
.crm-accordion-bold > summary
&.crm-accordion-light > summary
(this is a point with all the revised accordions)