Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up some old accordion classnames still being used with details/summary #29600

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Mar 2, 2024

The first new <details><summary> accordions created during the December 2023 sprint kept the old classes .crm-accordion-wrapper & .crm-accordion-header names for design consistency.

Once civicrm.css was updated to style details+summary directly, with utility classes .crm-accordion-bold > summary to replace .crm-accordion-header & .crm-accordion-light > summary to replace .crm-accordion-header.crm-master-accordion-header, those old class names stopped being needed. The recent accordion PRs (#29448, #29533) have already swapped the old class names/patterns to the new ones across most Civi accordions.

The JS file in particular needs updating as it generates accordions used in multiple parts of Civi.

Before

Old classnames.

After

New, fewer classnames.

Comments

Greenwich theme handles the new classnames. Other themes need to make sure they support .crm-accordion-bold > summary & .crm-accordion-light > summary (this is a point with all the revised accordions)

Copy link

civibot bot commented Mar 2, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 2, 2024
@JoeMurray
Copy link
Contributor

@seamuslee001 could you review before tomorrow's RC is cut?

@seamuslee001
Copy link
Contributor

These seem fine to me

@seamuslee001 seamuslee001 merged commit 3985491 into civicrm:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants