Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entity id in rows #29582

Merged
merged 1 commit into from
Mar 2, 2024
Merged

entity id in rows #29582

merged 1 commit into from
Mar 2, 2024

Conversation

MegaphoneJon
Copy link
Contributor

Overview

Adds an entity-id attribute when one exists to SK result rows.

Before

No entity-id.

After

Yes entity-id.

Comments

Even when entity-id isn't rendered (e.g. when aggregating), the ng-attr-entity-id is still present. Is that due to a debug mode or something? I used ngAttr because I thought it would be less verbose, but it's more verbose.

@civibot civibot
Copy link

civibot bot commented Mar 2, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 2, 2024
colemanw
colemanw reviewed Mar 2, 2024
View reviewed changes
ext/search_kit/ang/crmSearchDisplayTable/crmSearchDisplayTableBody.html Outdated
@@ -1,4 +1,4 @@
<tr ng-repeat="(rowIndex, row) in $ctrl.results">
<tr ng-repeat="(rowIndex, row) in $ctrl.results" ng-attr-entity-id="{{ row.key || undefined }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although I think the || undefined bit is redundant.

@MegaphoneJon
Copy link
Contributor Author

@colemanw I made the attribute conditional because I thought it would reduce the markup. But now that I understand that it increases the markup, I made entity-id unconditional.

@colemanw colemanw merged commit b82d936 into civicrm:master Mar 2, 2024
2 checks passed
@colemanw
Copy link
Member

colemanw commented Mar 2, 2024

Great

@MegaphoneJon MegaphoneJon mentioned this pull request Mar 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MegaphoneJon @colemanw