Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update Subscription Form] Align UpdateSubscription to more recent practices #29580

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[Update Subscription Form] Align UpdateSubscription to more recent practices #29580

merged 3 commits into from
Mar 6, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This attempts to address https://github.com/civicrm/civicrm-core/pull/28617/files#diff-c683b948c8375b8bcc28cea8d54c2210bf8e94e8229b151666c94db370970b36L77-R105 of the stale cleanup by by @mattwire by using some of the techniques we have worked on in the meantime

Before

notices

After

The goal is that getMembershipID() should be reliable & getMembershipValue() should be adequate to retrieve an assign a value - since this uses apiv4 rather than BAO values we need to ensure db escaping (also best practice)

Technical Details

This also applies the way of handling custom data we have been working on in similar PRs to use the preferred function at hte php level & ensure the parameters are passed at the tpl level https://github.com/civicrm/civicrm-core/pulls?q=is%3Apr+is%3Aopen+php8.2

Comments

I haven't given this a proper spin yet

@civibot civibot
Copy link

civibot bot commented Mar 2, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 2, 2024
@eileenmcnaughton eileenmcnaughton mentioned this pull request Mar 2, 2024
Closed
@totten
Copy link
Member

totten commented Mar 2, 2024

civibot, test this please

@eileenmcnaughton eileenmcnaughton force-pushed the payment_object_3 branch 2 times, most recently from 3a212a2 to ec9c0ad Compare March 2, 2024 19:29
@colemanw
Copy link
Member

colemanw commented Mar 2, 2024

@civicrm-builder retest this please

@eileenmcnaughton
Stop setting coid, contribution_recur_id, processor
92bd4e4 
All handled by parent preProcess
@eileenmcnaughton
Use preferred method to handle Custom data
bae584a 
This is in line with
civicrm#29228
and
civicrm#29241
and already converted forms and
1) handles localised money in custom fields
2) reduces notices
3) calls less legacy code
@eileenmcnaughton eileenmcnaughton changed the title Align UpdateSubscription to more recent practices [Update Subscription Form] Align UpdateSubscription to more recent practices Mar 5, 2024
@mattwire mattwire merged commit a2764a9 into civicrm:master Mar 6, 2024
3 checks passed
@eileenmcnaughton eileenmcnaughton deleted the payment_object_3 branch March 6, 2024 22:47
@eileenmcnaughton
Copy link
Contributor Author

thanks @mattwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @totten @colemanw @mattwire