if no clicks, display 0 rather than empty string

[jmcclelland]

Overview

The display of clicks in the Mailings tab shows an empty string instead of 0.

Before

Confusing - looks like the display of clicks is broken:

After

Now, clicks display properly as zero:

Technical Details

I love the NULL coalesce operator! Unfortunately, it only seems to work when assigning variables, not when appending. At least I think that is what is going wrong?

Comments

I also opted to make consistent the collection of both clicks and opens just so it's more readable. I think the coalesce operator is our preferred method rather than using CRM_Utils_Array::value?

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

It was probably that . is stronger than ?? so it was evaluating wrong, but either way. Since you're editing it, seems like it should have ts()?

[jmcclelland]

@demeritcowboy good catch! I just made the change. I considered using the 'count' argument, but I think: Clicks: 1 and Clicks: 2 reads more smoothly than: Click: 1 and Clicks: 2, right?

[demeritcowboy]

Going to ignore the infra test fails since it passed crm and api3 which is where any likely tests would be.