Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call browse directly rather than forcing through run #29481

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Call browse directly rather than forcing through run #29481

merged 1 commit into from
Mar 1, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Going through run() means a few variables are set one way rather than another but ultimate does nothing but confuse. The whole form is very overloaded so baby-steps

This is accessed to view the custom data tab

image

@eileenmcnaughton
Call browse directly rather than forcing through run
6c2ccbc 
Going through run() means a few variables are set one way rather than another but
ultimate does nothing but confuse. The whole form is very overloaded so baby-steps
@civibot civibot
Copy link

civibot bot commented Feb 23, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 23, 2024
eileenmcnaughton
eileenmcnaughton commented Feb 23, 2024
View reviewed changes
CRM/Contact/Page/View/CustomData.php
$page->set('action', CRM_Core_Action::BROWSE);
$page->set('multiRecordFieldListing', $multiRecordFieldListing);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this is not used by the form & looks a whole lot like copy & paste

@mattwire mattwire merged commit 7122a59 into civicrm:master Mar 1, 2024
3 checks passed
@eileenmcnaughton eileenmcnaughton deleted the multi branch March 1, 2024 20:36
@eileenmcnaughton
Copy link
Contributor Author

thanks @mattwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire