Assign profileID to template in UFNotify, add example #29441
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
57e0a04 to
6d09d5e
Compare
| protected $groupTitle; | ||
|
|
||
| public function getGroupTitle(): string { | ||
| return CRM_Core_DAO::getFieldValue('CRM_Core_DAO_UFGroup', $this->getProfileID(), 'title'); |
There was a problem hiding this comment.
@eileenmcnaughton should this be the public title?
There was a problem hiding this comment.
@seamuslee001 yeah that makes sense - it wasn't before but I think it should be
6d09d5e to
3b3b51c
Compare
|
@pradpnayak does this work for you? |
| protected $groupTitle; | ||
|
|
||
| public function getGroupTitle(): string { | ||
| return CRM_Core_DAO::getFieldValue('CRM_Core_DAO_UFGroup', $this->getProfileID(), 'frontend_title'); |
There was a problem hiding this comment.
I got error because my profile had missing frontend_title
TypeError: CRM_Core_WorkflowMessage_UFNotify::getGroupTitle(): Return value must be of type string, null returned in CRM_Core_WorkflowMessage_UFNotify->getGroupTitle() (line 65 of /Users/pradeep/Sites/drupal7/sites/all/modules/civicrm/CRM/Core/WorkflowMessage/UFNotify.php).
There was a problem hiding this comment.
How about using
CRM_Core_BAO_UFGroup::getFrontEndTitle($this->getProfileID());
There was a problem hiding this comment.
@pradpnayak did you test this by backporting it - in 5.72 frontend_title should be a required field
There was a problem hiding this comment.
My bad, tested by upgrading to 5.71 beta. The frontend title is not updated with the title field and the field is required through UI.
|
I did a quick test, i now get profile id and other info in hooks to alter. Before: 
After: 
|
|
This look good to merge besides the return type fatal error mentioned above. Thank you so much @eileenmcnaughton for doing a alternate PR. |
|
I have tested the above failure and it seems to work fine. This PR is good to merge. |
|
@seamuslee001 any last concerns? |
Overview
Assign profileID to template in UFNotify, add example
Before
Not possible to render example,
profileIDnot available, userDisplayName mixed with the person the profile relates toAfter
Technical Details
This started out as just a basic alternative to #29439 but I got carried away
Comments