Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS Trait - add support for Autocomplete subscriber, notice fix #29429

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 18, 2024

Overview

SMS Trait - add support for Autocomplete subscriber, notice fix

This just pulls out the Smarty notice fix, the function moves & the registration for the phone autocomplete widget from #29413 because there is still a bit to work through in there & these fixes can be added by themselves

Before

@colemanw's autocomplete support not in core, notice on SMSTemplate
image

Functions not in the trait

After

Above chunks done

Technical Details

@colemanw I think this will simplify working through the remaining parts

Comments

eileenmcnaughton and others added 4 commits February 19, 2024 11:25
I fixed 2 notices in the process by doing unconditional assigns & tested that the
formRule & postProcess are called. Other than the notices this is a straight move
Copy link

civibot bot commented Feb 18, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 18, 2024
@colemanw colemanw merged commit 452c778 into civicrm:master Feb 19, 2024
3 checks passed
@colemanw colemanw deleted the sms_fixes branch February 19, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants