dev/core#4999 [REF] - Extract some methods from CodeGen into a utility class #29364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small step toward https://lab.civicrm.org/dev/core/-/issues/4999
Function extraction makes CodeGen more readable, and the methods reusable.
Technical Details
The one functional change that's not a straight extraction is to return actual booleans for the 'usage' items (e.g.
usage.import = true
instead ofusage.import = "TRUE"
). This makes the function more sane to use and adapting the .tpl was simple. It'll probably invalidate all the checksums and require regenerating all DAO files... sigh.