[php8.2] Clean up the 2 forms that support Group-extending custom data for notices, php8.2 compliance

[eileenmcnaughton]

Overview

Clean up the 2 forms that support Group-extending custom data for notices, php8.2 compliance

Before

Forms use complex, non php8.2 compliant function to add the group custom data to the forms, various notices

After

Ajax method used to load the custom data, unlike the removed functions it has a clear contract

Technical Details

I'm pretty sure the noticey show-hide was another round of copy & paste. I tackled both these forms together because although only one is blocking our test suite they both required the same field to be configured. In addition the slight change in postProcess should handle money formatting

Comments

Anything else you would like the reviewer to note

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@jofranz not sure if you have any time to review - but getting this PR merged would clear up s couple of the remaining php8.2 test fails

[jofranz]

@jofranz not sure if you have any time to review - but getting this PR merged would clear up s couple of the remaining php8.2 test fails

Had a quick look. Looks good! Won't find time to test it tho. Let's give this a go :)

[colemanw]

Ok, this follows an established pattern & includes a test.