dev/core#4940 Switch variables for tokens in contribution invoice template

[eileenmcnaughton]

Overview

Switch contribution variable for tokens in contribution invoice template

Before

Variables tied to the form layer

After

Caller independent tokens used for most contribution variables

No change to output

but as we migrate away from our form dependency over time we can send these direct from SearchKit - this extension adds as an action https://github.com/eileenmcnaughton/send_message_action - although it has mostly been used for testing so far (hmm & it turns out that one day after I let Jack blow away my old laptop the main Form file was not committed to the repo)

Technical Details

A couple are left out

• invoice date - there are 2 options for this - no change {domain.now} or change to {contribution.receive_date) - I will put up separately - pending emoji poll results https://lab.civicrm.org/dev/core/-/issues/4940
• due date - this is an interesting one - maybe apiv4 should calculate it?

I also found the address_billing tokens are not working as they should - am investigating them for a separate fix

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[mmyriam]

@civicrm-builder retest this please

[mmyriam]

I tested all the modified variables and it's all good.

[eileenmcnaughton]

@mmyriam thank you very much - I know these things can be hard to test!

[eileenmcnaughton]

unrelated fail