-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standalone: fix double <h1> and padding on select2 drops dev/core#4831 #28560
standalone: fix double <h1> and padding on select2 drops dev/core#4831 #28560
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
@colemanw I've tagged you on this because it touches the angular code for identifying the "cms" page title. |
22cc572
to
4fc1c27
Compare
@colemanw ok the updated pr
|
4fc1c27
to
e98988c
Compare
I've tested in D10 (to check I hadn't broken previous behaviour) and standalone. |
Great work, thanks Rich & sorry for all the nitpickyness. |
@colemanw thanks for the merge, that messed up select2 padding was really annoying me! no worries about nitpickiness, a lot of standalone is still a mix of "I put this random code in here and it sort of worked" and better new code, so always good to question. |
Yea @artfulrobot I think some of the standalone templates were copied back from an ancient version of Civi so lots of outdated things to fix up. |
This regressed probably due to a combination of civicrm#28560 and civicrm#29694
Fixes https://lab.civicrm.org/dev/core/-/issues/4831 and also fixes problem introduced by #28471 that doubled the
<h1>
on angularjs pages.Before:
Now: