Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to processAmount #28463

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add warnings to processAmount #28463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CRM/Price/BAO/PriceSet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,22 @@ public static function initSet(&$form, $entityTable = 'civicrm_event', $doNotInc
* Line item array to be altered.
* @param int $priceSetID
*
* @deprecated since 5.69 will be removed around 5.85. This function is still in use but marking deprecated to make it clear that
* we are moving away from it. There is no function that has the guaranteed stable signature
* that would allow us to support if from outside of core so if using this or the core alternative
* from an extension you need to rely on unit tests to keep your code stable. Within core we
* already have good test cover on code that calls this.
*
* The recommended approach within core is something like
*
* private function initializeOrder(): void {
* $this->order = new CRM_Financial_BAO_Order();
* $this->order->setForm($this);
* $this->order->setPriceSelectionFromUnfilteredInput($this->>getSubmittedValues());
* }
*
* $lineItems = $this->order->getLineItems();
*
* @todo $priceSetID is a pseudoparam for permit override - we should stop passing it where we
* don't specifically need it & find a better way where we do.
*/
Expand Down