Fix tests calling AdditionalPayment form to use full flow, add standard ID get functions #28461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
b49cddd to
2d455b0
Compare
eileenmcnaughton
commented
Dec 4, 2023
| $title = $this->assignPaymentInfoBlock(); | ||
| $this->setTitle($title); | ||
| return; | ||
| } | ||
| if ($this->_component == 'event') { |
There was a problem hiding this comment.
moved to getContributionID()
eileenmcnaughton
commented
Dec 4, 2023
| @@ -309,9 +312,6 @@ public function postProcess() { | |||
| public function submit($submittedValues) { | |||
| $this->_params = $submittedValues; | |||
| $this->beginPostProcess(); | |||
| // _contributorContactID may no longer need to be set - setting it here | |||
| // was for use in processBillingAddress | |||
| $this->_contributorContactID = $this->_contactID; | |||
There was a problem hiding this comment.
unused, from previously shared code
eileenmcnaughton
commented
Dec 4, 2023
| @@ -425,27 +425,26 @@ public function processCreditCard() { | |||
| } | |||
|
|
|||
| $this->set('params', $this->_params); | |||
|
|
|||
| // set source if not set | |||
| if (empty($this->_params['source'])) { | |||
There was a problem hiding this comment.
unused, from previously shared code
eileenmcnaughton
commented
Dec 4, 2023
| ); | ||
| $this->_params['source'] = ts('Submit Credit Card Payment by: %1', [1 => $userSortName]); | ||
| } | ||
| return [ |
There was a problem hiding this comment.
Return payment processor values, this is used in a follow up
…ributionID() function
2d455b0 to
6876b7b
Compare
|
Opps I included one of my follow on changes - removed CRM_Contribute_Form_AdditionalPaymentTest::testAddPaymentUsingCreditCardForPartiallyPaidContribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
FIx tests caling AdditionalPayment form to use full flow, add getContributionID(), getPaymentProcessorID() functions
Before
tests call an artifical
testSubmit()functionAfter
tests use the FormTrait, standardised externally supported
getContributionID()added & testedTechnical Details
Also removes setting the source - this is from previously shared code where it set up the value for contribution source - but this form only interacts with the Payment api, not the contribution
Comments