Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#4411 fix issue with user language #28453

Merged

Conversation

jaapjansma
Copy link
Contributor

Overview

This PR does the following in standalone CiviCRM:

  • Add possibility to set a user language and if set that language is used for the UI when the user logs in
  • Freezes the element for inherit CMS Language under Administer > Localization > Languages, Currencies, Locations

See https://lab.civicrm.org/dev/core/-/issues/4411

@artfulrobot can you review this?

Copy link

civibot bot commented Dec 3, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 3, 2023
Copy link

civibot bot commented Dec 3, 2023

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4411

@jaapjansma jaapjansma force-pushed the standalone_language_and_timezone branch 2 times, most recently from bbbdcd8 to a6b3d67 Compare December 3, 2023 21:22
@jaapjansma
Copy link
Contributor Author

@colemanw thanks for your suggestion I took the suggestion over.
@artfulrobot I fixed the merge conflict and also a style warning.

@colemanw
Copy link
Member

colemanw commented Dec 3, 2023

@jaapjansma well done

@colemanw colemanw merged commit 9b97846 into civicrm:master Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants