dev/core#4778 - php notice causes civi menu to go missing

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/4778

Before

Menu missing - notice in console Undefined array key "adv_search_legacy"

After

Technical Details

Whether it borks your menu or not will depend on how strict your dev environment is setup. But at a minimum there's a php notice.

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4778

[colemanw]

Something is amiss here. In the commit from https://github.com/civicrm/civicrm-core/pull/28072/files#diff-633e3420e42e4f43c4549f67e08417d7007aeecd5062b1814b93a40c966f710bL83
it's been changed to

$allOptions = array_column(CRM_Core_SelectValues::getQuicksearchOptions(), NULL, 'key');

But this PR makes it look like that line somehow got reverted.

[demeritcowboy]

Not sure what you mean? Line 83 here looks the same as the line you're referencing in the other commit?

[demeritcowboy]

An alternate would be to explicitly put empty values 'adv_search_legacy' => '', in the static array at

civicrm-core/CRM/Core/SelectValues.php

Lines 1122 to 1139 in 50b66a5

	$options = [
	[
	'key' => 'sort_name',
	'label' => $includeEmail ? ts('Name/Email') : ts('Name'),
	],
	[
	'key' => 'id',
	'label' => ts('Contact ID'),
	],
	[
	'key' => 'external_identifier',
	'label' => ts('External ID'),
	],
	[
	'key' => 'first_name',
	'label' => ts('First Name'),
	],
	[

[colemanw]

Ok you're right @demeritcowboy. I see it now. Ok this fix is correct.