PHP 8.x: fix TypeError in config hook #27996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using vanilla CiviCRM with the old ckeditor 4, attempting to upload a file results in a fatal TypeError on PHP 8.0 and later.
To reproduce:
Before
After
no error
Technical Details
Changing the function definition to default to
$flags = []
didn't seem to help, so I opted for an ugly fix.I opened this PR against the RC, because it's a fatal PHP 8 bug.