Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test call to PaypalPro sandbox from tests #27953

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove test call to PaypalPro sandbox from tests

Before

a test has started failing in the contribution test class that attempts to create a payment with the paypal sandbox

After

Test uses the dummy processor

Technical Details

It's unclear if the test fail is telling us there is a problem with our test account or paypal's sandbox site or a change in paypal end contract but it's not really the appropriate for paypal end issues to surface in our unit tests. Since we started hitting the paypal sandbox we added a separate class to test PaypalPro via guzzle & we have other tests on our forms.

Note the error from paypal is a decline without much more info.

Comments

@civibot
Copy link

civibot bot commented Oct 27, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 27, 2023
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

I'm gonna take this on myself to merge this just to get away from these fails affecting all PRs - can revert if people have another idea

@eileenmcnaughton eileenmcnaughton merged commit a1be4e0 into civicrm:master Oct 27, 2023
@eileenmcnaughton eileenmcnaughton deleted the no_paypal branch October 27, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant